kvserver: ignore errors encountered while removing live learners #80918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a set of failures noticed in cockroachdb#79887 where a bunch of `EXPERIMENTAL_RELOCATE` calls failed because they tried removing learner replicas that are in the process of receiving their initial snapshot. Removing learners in this state is disallowed as of cockroachdb#79379. This commit fixes a subset of those failures by making the `kv50/rangelookups` roachtest ignore these errors. Relates to cockroachdb#79887 Release note: None
|
This change is |
tbg
approved these changes
May 3, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @lidorcarmel and @nvanbenschoten)
|
TFTR bors r+ |
|
Build succeeded: |
|
blathers backport 22.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a set of failures noticed in #79887 where a bunch of
EXPERIMENTAL_RELOCATEcalls failed because they tried removing learnerreplicas that are in the process of receiving their initial snapshot. The test simply
randomly issues these
RELOCATEcalls so this behavior is intentional.Removing learners in this state is disallowed as of #79379. This commit fixes a
subset of those failures by making the
kv50/rangelookupsroachtest ignorethese errors.
Relates to #79887
Release note: None