-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: kv50/rangelookups/relocate/nodes=8 failed [waiting for backport] #79887
Comments
cockroach/pkg/kv/kvserver/replica_command.go Lines 2930 to 2935 in c99bd0c
None of these were recently touched. |
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 6c91da48b8da78c13e4cb8675a1a98c5ec75ea06:
|
I think this is fallout from #79405. We need to change this fast-path conditional get condition to guarantee the absence of learners. That's a little awkward because the interface of |
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 1fdbb16fa206c5fd77c3aa111ec40916edfb55df:
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 0add8527e82d0ae4987ea7105778c7aa6e43bd3a:
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 8fe42c18e5e2a82494fa6a34e068f4ab801f87c4:
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 36b190afcffec66272bd5485567757b1a106c9e0:
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 2fdc0a62df08829dd96901fffb5fb1fbb0b0997d:
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 72e485705aa859ef850ebc67568bc29fe9b7cfd6:
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 97e72bacbeb9574f09f7475a62ef45c3e228183e:
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ a2e1910f51593bd2ef72e1d7c615e08f95791186:
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ c9e0194b19a03d55c6be92572aad3fbafc256334:
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 7a9eb906ce86e2f75db637e29d46cd6604fca7b4:
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 01572daaf94f80f81f843723a8b58d80fe128990:
|
This commit fixes a set of failures noticed in cockroachdb#79887 where a bunch of `EXPERIMENTAL_RELOCATE` calls failed because they tried removing learner replicas that are in the process of receiving their initial snapshot. Removing learners in this state is disallowed as of cockroachdb#79379. This commit fixes a subset of those failures by making the `kv50/rangelookups` roachtest ignore these errors. Relates to cockroachdb#79887 Release note: None
80918: kvserver: ignore errors encountered while removing live learners r=aayushshah15 a=aayushshah15 This commit fixes a set of failures noticed in #79887 where a bunch of `EXPERIMENTAL_RELOCATE` calls failed because they tried removing learner replicas that are in the process of receiving their initial snapshot. The test simply randomly issues these `RELOCATE` calls so this behavior is intentional. Removing learners in this state is disallowed as of #79379. This commit fixes a subset of those failures by making the `kv50/rangelookups` roachtest ignore these errors. Relates to #79887 Release note: None Co-authored-by: Aayush Shah <[email protected]>
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ b0a8d28feb8befa417933d0a2ee99511b16414a1:
Parameters: Same failure on other branches
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ aadbaf97b4e6092ad6978a28e2735715d64d9f10:
Parameters: Same failure on other branches
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 8d34ef1ea15850ee1c70470610b6652df4c317de:
Parameters: Same failure on other branches
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 7a1ced4a49d28f66f381e78733bcab510e2cbafe:
Parameters: Same failure on other branches
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 7af6c0d3e2085cafda90d5f0b15d06f6a360f154:
Parameters: Same failure on other branches
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ fc7ae339c3f85ad2a2b28643e47d7c20768fe237:
Parameters: Same failure on other branches
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ b47dc374417fe4ba83570784040da5650238b30e:
Parameters: Same failure on other branches
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ a611410e3babe97a14152381b89060e1bafa2e27:
Parameters: Same failure on other branches
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ ac11a55499120ffd33016feebc47b4ed43a21007:
Parameters: Same failure on other branches
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 78caa5c3a8ecd0d0a612798a106b626edb3db2ee:
Parameters: Same failure on other branches
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 4e8134033890c956d39020f28a0e99b21b32649f:
Parameters: Same failure on other branches
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 3c9b17113488d2ee6929936aa6ec48396f3ed71c:
Parameters: Same failure on other branches
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ b9a165c03643ed43a0d45b16c0a795244543a2fe:
Parameters: Same failure on other branches
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 33d70998719051ee058bc9e516afa238ea7b7451:
Parameters: Same failure on other branches
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 03d5260a467b8640de41ee08054c1ce05f91966c:
Parameters: Same failure on other branches
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 88789feea153b61b379c0240a07482bdfaf0c932:
Parameters: Same failure on other branches
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 6374bd83f192bd509e50313acb431690b9c3f8ae:
Parameters: Same failure on other branches
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 86e007dcb5cbde3501f138c1d768519db3487857:
Parameters: Same failure on other branches
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 571bfa3afb3858ae84d8a8fcdbb0a38e058402a5:
Parameters: Same failure on other branches
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 687171ac6c2cd9992486bb3b8c9d252ac95ca1cd:
Parameters: Same failure on other branches
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 88d3253301457ac57820e0f4a4fab8f74bf9f38b:
Parameters: Same failure on other branches
|
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ e9ee21860458d997a8155734dc608cfcd050ef24:
Parameters: Same failure on other branches
|
The diagnosis of this issue was in #79887 (comment). This is still failing after #80918. It's unclear to me whether that is expected or not, or whether we're still waiting on #80205. @aayushshah15 do you know? Were you still planning to push #80205 over the finish line? |
We have marked this test failure issue as stale because it has been |
roachtest.kv50/rangelookups/relocate/nodes=8 failed with artifacts on master @ 43457fc6e2f5324823cca4156d9799453753b9cc:
Help
See: roachtest README
See: How To Investigate (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-15876
The text was updated successfully, but these errors were encountered: