Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testcluster: avoid infinite hang in WaitForNStores #80629

Merged
merged 1 commit into from
Apr 29, 2022
Merged

testcluster: avoid infinite hang in WaitForNStores #80629

merged 1 commit into from
Apr 29, 2022

Conversation

tbg
Copy link
Member

@tbg tbg commented Apr 27, 2022

Fail gracefully instead of timing out the test suite.

See #80619 (comment)

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg tbg marked this pull request as ready for review April 27, 2022 13:23
@tbg tbg requested a review from a team April 27, 2022 13:23
@tbg
Copy link
Member Author

tbg commented Apr 27, 2022

Hold off, did something silly here. Will ping.

@tbg
testcluster: avoid infinite hang in WaitForNStores
8bac3f5 
Fail gracefully instead of timing out the test suite.

See cockroachdb#80619 (comment)

Release note: None
@tbg tbg force-pushed the waitforn-timeout branch from a3c0478 to 8bac3f5 Compare April 27, 2022 13:28
@tbg tbg requested a review from aliher1911 April 27, 2022 14:30
@tbg
Copy link
Member Author

tbg commented Apr 28, 2022

Ping.

@tbg tbg requested review from a team and otan and removed request for a team April 29, 2022 11:11
srosenberg
srosenberg approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@srosenberg srosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the timeout!

@tbg
Copy link
Member Author

tbg commented Apr 29, 2022

bors r=srosenberg

@craig
Copy link
Contributor

craig bot commented Apr 29, 2022

Build succeeded:

@craig craig bot merged commit a2e1910 into cockroachdb:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srosenberg srosenberg srosenberg approved these changes

@aliher1911 aliher1911 Awaiting requested review from aliher1911

@otan otan Awaiting requested review from otan otan was automatically assigned from cockroachdb/test-eng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbg @cockroach-teamcity @srosenberg