kvserver: raft{Request->Receive}Queue #80619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This clarifies that this queue holds received raft messages (not messages waiting to be sent). Release note: None
|
This change is |
erikgrinaker
approved these changes
Apr 27, 2022
|
bors r=erikgrinaker |
|
Build failed: |
Now I'm not sure if it's related, but we're seeing mvccGC get tripped up on the spanset checks repeatedly, and this is on the liveness range: |
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Apr 27, 2022
Fail gracefully instead of timing out the test suite. See cockroachdb#80619 (comment) Release note: None
|
bors r=erikgrinaker |
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Apr 27, 2022
See cockroachdb#80619 (comment). My understanding is that in `MVCCGarbageCollect`, we look at each `key`. First, we seek the iterator to construct the `MVCCMetadata` (if there is one), so we're here: ``` key @ ts=100 <-- iter key @ ts=099 ... key @ ts=007 key @ ts=006 key @ ts=005 ``` If we want to GC at timestamp, say, 6, we need to iterate forwards. To avoid calling `Next()` too many times, eventually we'll instead `SeekLT(key @ 6)`. But we only hold the latch for `key`, so we can't seek into `[/Min, key)`. Disable the spanset assertions here. We use the result of `SeekLT` only if it puts us into keyspace covered by the latch. An import cycle (spanset - storage - spanset) made this require a small refactor. Release note: None
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Apr 29, 2022
80629: testcluster: avoid infinite hang in WaitForNStores r=srosenberg a=tbg Fail gracefully instead of timing out the test suite. See #80619 (comment) Release note: None 80781: sql/importer: skip TestRandomParquetExports r=tbg a=tbg Refs: #80780 Reason: flaky test Generated by bin/skip-test. Release justification: non-production code changes Release note: None 80783: sql: skip TestCancelMultipleQueued r=tbg a=tbg Refs: #80782 Reason: flaky test Generated by bin/skip-test. Release justification: non-production code changes Release note: None Co-authored-by: Tobias Grieger <[email protected]>
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Jun 8, 2022
See cockroachdb#80619 (comment). My understanding is that in `MVCCGarbageCollect`, we look at each `key`. First, we seek the iterator to construct the `MVCCMetadata` (if there is one), so we're here: ``` key @ ts=100 <-- iter key @ ts=099 ... key @ ts=007 key @ ts=006 key @ ts=005 ``` If we want to GC at timestamp, say, 6, we need to iterate forwards. To avoid calling `Next()` too many times, eventually we'll instead `SeekLT(key @ 6)`. But we only hold the latch for `key`, so we can't seek into `[/Min, key)`. Disable the spanset assertions here. We use the result of `SeekLT` only if it puts us into keyspace covered by the latch. An import cycle (spanset - storage - spanset) made this require a small refactor. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jun 8, 2022
80636: kvserver: avoid spanset assertion in MVCCGarbageCollect r=nvanbenschoten a=tbg See #80619 (comment). My understanding is that in `MVCCGarbageCollect`, we look at each `key`. First, we seek the iterator to construct the `MVCCMetadata` (if there is one), so we're here: ``` key @ ts=100 <-- iter key @ ts=099 ... key @ ts=007 key @ ts=006 key @ ts=005 ``` If we want to GC at timestamp, say, 6, we need to iterate forwards. To avoid calling `Next()` too many times, eventually we'll instead `SeekLT(key @ 6)`. But we only hold the latch for `key`, so we can't seek into `[/Min, key)`. Release note: None Co-authored-by: Tobias Grieger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clarifies that this queue holds received raft messages (not
messages waiting to be sent).
These changes were mechanical, via Goland.
Release note: None