[custom-build] sql/rowexec: subject column backfills to admission control #79117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
erikgrinaker
force-pushed
the
backfill-admission-control-21.2.7
branch
2 times, most recently
from
575f922 to
506782b
Compare
ajwerner
force-pushed
the
backfill-admission-control-21.2.7
branch
from
506782b to
c7cae6e
Compare
Release note (bug fix): Previously IMPORT INTO could create duplicate entries UNIQUE constraints in REGIONAL BY ROW tables and tables utilizing UNIQUE WITHOUT INDEX constraints. A new post-IMPORT validation step for those tables now fails and rolls back the IMPORT in such cases.
Before this patch, when no bytes were admitted in an interval, we'd assume that the correct estimate per byte was 1. This meant that we could see a huge jump in tokens which effectively disabled the throttling of admission control. Release note (bug fix): Fixed a bug in IO admission control which could result in admission control failing to rate-limit when traffic was stalled such that no work was admitted, despite the store's being in an unhealthy state.
ajwerner
force-pushed
the
backfill-admission-control-21.2.7
branch
2 times, most recently
from
f8c1f60 to
31c5d9d
Compare
cockroachdb/pebble#1625 Release note: None
ajwerner
force-pushed
the
backfill-admission-control-21.2.7
branch
from
31c5d9d to
38835a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary 21.2 backport of #79115 and friends, for a custom build.