crl-release-21.2: compaction: incorporate L0 size into compaction priority #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
itsbilal
approved these changes
Apr 5, 2022
ajwerner
added a commit
to cockroachdb/cockroach
that referenced
this pull request
Apr 5, 2022
cockroachdb/pebble#1625 Release note: None
ajwerner
added a commit
to cockroachdb/cockroach
that referenced
this pull request
Apr 5, 2022
cockroachdb/pebble#1625 Release note: None
nicktrav
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jbowens)
Currently, L0's compaction picking score is determined only by the number of sublevels. This doesn't account for scenarios where L0 consists of many non-overlapping files. Adjust the compaction heuristic to the maximum of scores computed from sublevels and size. See cockroachdb#1623.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, L0's compaction picking score is determined only by the
number of sublevels. This doesn't account for scenarios where L0
consists of many non-overlapping files. Adjust the compaction heuristic
to the maximum of scores computed from sublevels and size.
See #1623.