-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: remove unnecessary uses of lodash in database pages #78203
Conversation
Closes cockroachdb#68820 This commit removes the ue of functions from the lodash function where regular JS can be used. Release note: None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we purge the lodash from our package.json
as well ?
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)
Unfortunately we're still using it in other places. Most of the use cases are from years ago and can be replaced with simple JS (e.g. |
Agreed with Xin Hao, that there are still some places where lodash is useful. Lodash also exports the functions individually, so if we can define a specific set that we want to use we can just import those. I think it's a question of what our goals and priorities are. I also think this might also involve a bigger picture of frontend decisions. For instance, |
TFTR! |
Build failed (retrying...): |
Build succeeded: |
Closes #68820
This commit removes the ue of functions from the lodash function
where regular JS can be used.
Release note: None