Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: replace lodash with vanilla Array methods where possible in the databases pages #68820

Closed
matthewtodd opened this issue Aug 12, 2021 · 0 comments · Fixed by #78203
Closed

ui: replace lodash with vanilla Array methods where possible in the databases pages #68820

matthewtodd opened this issue Aug 12, 2021 · 0 comments · Fixed by #78203
Assignees
@xinhaoz
Labels
A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced.

Comments

@matthewtodd
Copy link
Contributor

matthewtodd commented Aug 12, 2021 •
edited by cockroach-jira-scripts
Loading

As a quick-fix follow to #68390.

Jira issue: CRDB-9284
@matthewtodd matthewtodd added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-observability A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console labels Aug 12, 2021
@matthewtodd matthewtodd added the E-quick-win Likely to be a quick win for someone experienced. label Aug 12, 2021
@xinhaoz xinhaoz self-assigned this Mar 21, 2022
@xinhaoz xinhaoz mentioned this issue Mar 21, 2022
Merged
craig bot pushed a commit that referenced this issue Mar 22, 2022
@tbg @xinhaoz
Merge #78174 #78203
e0a4c51 
78174: kvserver: don't use caller's context for ProposalData r=[erikgrinaker,nvanbenschoten] a=tbg

Fixes #75656.

Release note: None


78203: ui: remove unnecessary uses of lodash in database pages r=xinhaoz a=xinhaoz

Closes #68820

This commit removes the ue of functions from the lodash function
where regular JS can be used.

Release note: None

Co-authored-by: Tobias Grieger <[email protected]>
Co-authored-by: Xin Hao Zhang <[email protected]>
@craig craig bot closed this as completed in 68d9b53 Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xinhaoz xinhaoz

Labels
A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: remove unnecessary uses of lodash in database pages xinhaoz/cockroach
2 participants
@matthewtodd @xinhaoz