Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: update 22.1 version map to v21.2.7 #77780

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

Azhng
Copy link
Contributor

@Azhng Azhng commented Mar 14, 2022

Release note: None
Release justification: non-production code change.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@Azhng Azhng requested a review from a team March 14, 2022 17:22
Copy link
Collaborator

@celiala celiala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Azhng
Copy link
Contributor Author

Azhng commented Mar 15, 2022

bors r=celiala

craig bot pushed a commit that referenced this pull request Mar 15, 2022
76834: sql: execute batch statements in an implicit transaction r=otan a=rafiss

fixes #44803
relates to #76490

Release justification: high value bug fix to existing functionality 

### *: prepare tests for batch stmt txn change

This commit will make the next one easier to review.

### sql: execute batch statements in an implicit transaction

Release note (bug fix): Previously statements that arrived in a batch
during the simple query protocol would all execute in their own implicit
transactions. Now, we match the Postgres wire protocol, so all these
statements share the same implicit transaction. If a BEGIN is included
in a statement batch, then the existing implicit transaction is
upgraded to an explicit transaction.

### sql: add session var for old implicit txn behavior

Release note (sql change): The enable_implicit_transaction_for_batch_statements
session variable was added. It defaults to true. When it is true,
multiple statements in a single query (a.k.a. a "batch statement") will
all be run in the same implicit transaction, which matches the Postgres
wire protocol. This setting is provided for users who want to preserve
the behavior of CockroachDB versions v21.2 and earlier.

77780: roachtest: update 22.1 version map to v21.2.7 r=celiala a=Azhng

Release note: None
Release justification: non-production code change.

77781: cloud: bump orchestrator to v21.2.7 r=celiala a=Azhng

Release note: None
Release justification: non-production code change.

77803: kvserverbase: move MaxCommandSizeDefault out of kvserver r=ajwerner a=ajwerner

```
$ bazel query "somepath(//pkg/sql, //pkg/kv/kvserver)"
INFO: Empty results
Loading: 0 packages loaded
```

Release justification: non-production code changes

Release note: None

Co-authored-by: Rafi Shamim <[email protected]>
Co-authored-by: Azhng <[email protected]>
Co-authored-by: Andrew Werner <[email protected]>
@craig
Copy link
Contributor

craig bot commented Mar 15, 2022

This PR was included in a batch that was canceled, it will be automatically retried

@Azhng
Copy link
Contributor Author

Azhng commented Mar 16, 2022

bors r=celiala

@craig
Copy link
Contributor

craig bot commented Mar 16, 2022

Build succeeded:

@craig craig bot merged commit 0184736 into master Mar 16, 2022
@craig craig bot deleted the update-version-map-for-22.1 branch March 16, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants