-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: asyncpg failed #76490
Comments
It seems like all the failures are
|
roachtest.asyncpg failed with artifacts on master @ 9514f13d0190849eda12b39e272c278b82c269f4:
|
roachtest.asyncpg failed with artifacts on master @ 6d9ceec64fa120113c484d17e3f61dfd6737b221:
|
Gonna keep an eye out on this one to see more failures. |
roachtest.asyncpg failed with artifacts on master @ a7449866f3229872d92e1de973e209838f07de35:
|
roachtest.asyncpg failed with artifacts on master @ 978744dbb94b03497154547ce7fa97ea3be9a401:
|
lets see if the |
roachtest.asyncpg failed with artifacts on master @ 8e7248296a2b8b2a4d07dd82678c687a02d56c4f:
|
roachtest.asyncpg failed with artifacts on master @ eee8ef080a95bc59eb3ddc2bebf623eb78e78db9:
|
roachtest.asyncpg failed with artifacts on master @ 9b45e990d5ddbbd6da13e8d3e312bb251fe0233a:
|
roachtest.asyncpg failed with artifacts on master @ d89e743edc44da85d9bf4e9087b451e11d3628bd:
|
roachtest.asyncpg failed with artifacts on master @ e151a24dc1d495bf694e1e1c3ee8acb518c1424e:
|
@RichardJCai it looks like #77059 didn't fix this, and those two tests are failing reliably. Could you verify that the failures isn't a regression, then mark them as expected to fail? |
roachtest.asyncpg failed with artifacts on master @ dbdbb93978a9ad564e07085c15807f415ccaa00a:
|
roachtest.asyncpg failed with artifacts on master @ 0e1edf3ad9da29b1d3bb28fcfc0f293d700e3cb9:
|
roachtest.asyncpg failed with artifacts on master @ 71eb44ffb1574350cf4a36143ed423f6ac0ca02b:
|
roachtest.asyncpg failed with artifacts on master @ 3b7f761f019c0457c19726bab8d14c231cd318fc:
|
roachtest.asyncpg failed with artifacts on master @ c6a5a395cbecbbd5ba77c2c14e3bf68eb59eeb19:
|
roachtest.asyncpg failed with artifacts on master @ e7e596ede9d3da877e313a3d39ab498a5cb7d27b:
|
roachtest.asyncpg failed with artifacts on master @ 5755663effbdbe8175bb74e5cdc19b2298e0a0bc:
|
roachtest.asyncpg failed with artifacts on master @ 0069e980d756ca580167eb321ac6b348b35313f0:
|
looks like my change in #76834 actually fixes |
roachtest.asyncpg failed with artifacts on master @ 270eb7b3ab88fc47ba86d87f4e2113e560f047a8:
|
roachtest.asyncpg failed with artifacts on master @ dc5432d65b9c38ce1ce5832e3c49d345b66145dc:
|
roachtest.asyncpg failed with artifacts on master @ 231fd420c61e39b6ad08c982c496d82cf1910bc5:
|
roachtest.asyncpg failed with artifacts on master @ f5fc84fb5707428ae9505c5e3e90cf3f63d465ad:
|
76834: sql: execute batch statements in an implicit transaction r=otan a=rafiss fixes #44803 relates to #76490 Release justification: high value bug fix to existing functionality ### *: prepare tests for batch stmt txn change This commit will make the next one easier to review. ### sql: execute batch statements in an implicit transaction Release note (bug fix): Previously statements that arrived in a batch during the simple query protocol would all execute in their own implicit transactions. Now, we match the Postgres wire protocol, so all these statements share the same implicit transaction. If a BEGIN is included in a statement batch, then the existing implicit transaction is upgraded to an explicit transaction. ### sql: add session var for old implicit txn behavior Release note (sql change): The enable_implicit_transaction_for_batch_statements session variable was added. It defaults to true. When it is true, multiple statements in a single query (a.k.a. a "batch statement") will all be run in the same implicit transaction, which matches the Postgres wire protocol. This setting is provided for users who want to preserve the behavior of CockroachDB versions v21.2 and earlier. 77780: roachtest: update 22.1 version map to v21.2.7 r=celiala a=Azhng Release note: None Release justification: non-production code change. 77781: cloud: bump orchestrator to v21.2.7 r=celiala a=Azhng Release note: None Release justification: non-production code change. 77803: kvserverbase: move MaxCommandSizeDefault out of kvserver r=ajwerner a=ajwerner ``` $ bazel query "somepath(//pkg/sql, //pkg/kv/kvserver)" INFO: Empty results Loading: 0 packages loaded ``` Release justification: non-production code changes Release note: None Co-authored-by: Rafi Shamim <[email protected]> Co-authored-by: Azhng <[email protected]> Co-authored-by: Andrew Werner <[email protected]>
76834: sql: execute batch statements in an implicit transaction r=otan a=rafiss fixes #44803 relates to #76490 Release justification: high value bug fix to existing functionality ### *: prepare tests for batch stmt txn change This commit will make the next one easier to review. ### sql: execute batch statements in an implicit transaction Release note (bug fix): Previously statements that arrived in a batch during the simple query protocol would all execute in their own implicit transactions. Now, we match the Postgres wire protocol, so all these statements share the same implicit transaction. If a BEGIN is included in a statement batch, then the existing implicit transaction is upgraded to an explicit transaction. ### sql: add session var for old implicit txn behavior Release note (sql change): The enable_implicit_transaction_for_batch_statements session variable was added. It defaults to true. When it is true, multiple statements in a single query (a.k.a. a "batch statement") will all be run in the same implicit transaction, which matches the Postgres wire protocol. This setting is provided for users who want to preserve the behavior of CockroachDB versions v21.2 and earlier. Co-authored-by: Rafi Shamim <[email protected]>
removing blocker since #77865 was backported and fixes these tests. we should still update the asyncpg_blocklist though |
77370: orm: update asyncpg_blocklist r=rafiss a=RichardJCai Release justification: ORM test only change Release note: None Fixes #76490 Co-authored-by: richardjcai <[email protected]>
roachtest.asyncpg failed with artifacts on master @ bbb473c8f304ac20fec51ff0a0d04e128383bcf6:
Help
See: roachtest README
See: How To Investigate (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-13147
The text was updated successfully, but these errors were encountered: