Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: cli: fix the process exit status codes #70676

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

knz
Copy link
Contributor

@knz knz commented Sep 24, 2021

Backport 1/1 commits from #70673.

/cc @cockroachdb/release


Found by @jbowens in #70637.
We'll want to backport this. cc @joshimhoff

Release note (bug fix): The exit status of the cockroach command
did not follow the previously-documented table of exit status codes
when an error occurred during the command start-up. (Only errors
occuring after startup were reported using the correct code.)
This defect has been fixed. This bug had existed ever since reference
exit status codes had been introduced.


Release justification: bug fix necessary for monitoring and orchestration

@knz knz requested a review from a team as a code owner September 24, 2021 09:20
@blathers-crl
Copy link

blathers-crl bot commented Sep 24, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz requested review from otan and jbowens September 24, 2021 09:20
@knz knz force-pushed the backport21.2-70673 branch from 7fb2126 to 07a4261 Compare September 24, 2021 11:39
Release note (bug fix): The exit status of the `cockroach` command
did not follow the previously-documented table of exit status codes
when an error occurred during the command start-up. (Only errors
occuring after startup were reported using the correct code.)
This defect has been fixed. This bug had existed ever since reference
exit status codes had been introduced.
@knz knz force-pushed the backport21.2-70673 branch from 07a4261 to 25c21ab Compare September 24, 2021 16:12
@knz knz merged commit 9336e93 into cockroachdb:release-21.2 Sep 28, 2021
@knz knz deleted the backport21.2-70673 branch September 28, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants