Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: fix the process exit status codes #70673

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Conversation

knz
Copy link
Contributor

@knz knz commented Sep 24, 2021

Found by @jbowens in #70637.
We'll want to backport this. cc @joshimhoff

Release note (bug fix): The exit status of the cockroach command
did not follow the previously-documented table of exit status codes
when an error occurred during the command start-up. (Only errors
occuring after startup were reported using the correct code.)
This defect has been fixed. This bug had existed ever since reference
exit status codes had been introduced.

@knz knz requested review from jbowens and otan September 24, 2021 08:57
@knz knz requested a review from a team as a code owner September 24, 2021 08:57
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz
Copy link
Contributor Author

knz commented Sep 24, 2021

blathers backport 21.2

@knz
Copy link
Contributor Author

knz commented Sep 24, 2021

blathers backport 21.1

@blathers-crl
Copy link

blathers-crl bot commented Sep 24, 2021

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from fd9670f8d847b878922b26c01925a5529aec91c9 to blathers/backport-release-21.1-70673: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.1 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thanks!

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @otan)

Release note (bug fix): The exit status of the `cockroach` command
did not follow the previously-documented table of exit status codes
when an error occurred during the command start-up. (Only errors
occuring after startup were reported using the correct code.)
This defect has been fixed. This bug had existed ever since reference
exit status codes had been introduced.
@knz
Copy link
Contributor Author

knz commented Sep 24, 2021

TFYR!

bors r=jbowens

@craig
Copy link
Contributor

craig bot commented Sep 24, 2021

Build succeeded:

@craig craig bot merged commit ad275ab into cockroachdb:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants