-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: fix the process exit status codes #70673
Conversation
blathers backport 21.2 |
blathers backport 21.1 |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from fd9670f8d847b878922b26c01925a5529aec91c9 to blathers/backport-release-21.1-70673: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.1 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @otan)
Release note (bug fix): The exit status of the `cockroach` command did not follow the previously-documented table of exit status codes when an error occurred during the command start-up. (Only errors occuring after startup were reported using the correct code.) This defect has been fixed. This bug had existed ever since reference exit status codes had been introduced.
TFYR! bors r=jbowens |
Build succeeded: |
Found by @jbowens in #70637.
We'll want to backport this. cc @joshimhoff
Release note (bug fix): The exit status of the
cockroach
commanddid not follow the previously-documented table of exit status codes
when an error occurred during the command start-up. (Only errors
occuring after startup were reported using the correct code.)
This defect has been fixed. This bug had existed ever since reference
exit status codes had been introduced.