Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: sql: interleaved tables notice was incorrectly labeled as an error #70536

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 21, 2021

Backport 1/1 commits from #70525 on behalf of @fqazi.

/cc @cockroachdb/release


Previously, interleaved tables were only deprecated, and
later on we fully dropped support for them returning a new
notice with the word "error" indicating they were no-ops. This
was inadequates because the message is not fatal and only a notice.
To address this, this patch will change them message type to notice.

Release note: None


Release justification: Low risk fix changing a message from error to notice

Fixes: #70526

Previously, interleaved tables were only deprecated, and
later on we fully dropped support for them returning a new
notice with the word "error" indicating they were no-ops. This
was inadequates because the message is not fatal and only a notice.
To address this, this patch will change them message type to notice.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team September 21, 2021 22:32
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-21.2-70525 branch from fa7d608 to 4dcd66a Compare September 21, 2021 22:32
@blathers-crl blathers-crl bot requested a review from ajwerner September 21, 2021 22:32
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 21, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@postamar postamar added the do-not-merge bors won't merge a PR with this label. label Nov 1, 2021
@rafiss rafiss added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 29, 2021
@rafiss
Copy link
Collaborator

rafiss commented Nov 29, 2021

@fqazi friendly ping - does this need to be merged still?

@fqazi
Copy link
Collaborator

fqazi commented Nov 29, 2021

Yes, let me fix this up. I some how lost track of this, good catch @rafiss

@fqazi fqazi merged commit d0739e9 into release-21.2 Nov 29, 2021
@fqazi fqazi deleted the blathers/backport-release-21.2-70525 branch November 29, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. do-not-merge bors won't merge a PR with this label. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants