Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: interleaved tables notice was incorrectly labeled as an error #70526

Closed
fqazi opened this issue Sep 21, 2021 · 0 comments
Closed

sql: interleaved tables notice was incorrectly labeled as an error #70526

fqazi opened this issue Sep 21, 2021 · 0 comments
Assignees
@fqazi
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@fqazi
Copy link
Collaborator

fqazi commented Sep 21, 2021

The message is correctly generated as a NOTICE, but we use a pgerror which can be confusing for users. So, instead, generate a pgnotice instead.
@fqazi fqazi added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Sep 21, 2021
@fqazi fqazi self-assigned this Sep 21, 2021
@craig craig bot closed this as completed in 12a943b Sep 21, 2021
blathers-crl bot pushed a commit that referenced this issue Sep 21, 2021
@fqazi
sql: interleaved tables notice was incorrectly labeled as an error
4dcd66a 
Fixes: #70526

Previously, interleaved tables were only deprecated, and
later on we fully dropped support for them returning a new
notice with the word "error" indicating they were no-ops. This
was inadequates because the message is not fatal and only a notice.
To address this, this patch will change them message type to notice.

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fqazi fqazi

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fqazi