release-21.1: log,importccl,backupccl: add event logs for import and restore jobs #62830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
approved these changes
Mar 30, 2021
|
Lgtm |
adityamaru
force-pushed
the
backport21.1-62658
branch
from
964a159 to
71225ee
Compare
This change adds a new `CommonJobEventDetails` and two implementations of the interface in `Import` and `Restore`, to structure the events emitted during different phases of the job execution. Both Import/Restore will emit logs at the following stages: - When the job has completed preparing and is beginning execution. - When the job has succeeded. - When the job has started reverting. - When the job has finished reverting and is in a terminal failed state. Release note (sql change): IMPORT and RESTORE now emit structured events to the OPS channel. Refer to the generated documentation for details.
adityamaru
force-pushed
the
backport21.1-62658
branch
from
71225ee to
25c9856
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #62658.
/cc @cockroachdb/release
This change adds a new
CommonJobEventDetailsand two implementationsof the interface in
ImportandRestore, to structure the eventsemitted during different phases of the job execution.
Both Import/Restore will emit logs at the following stages:
Fixes: #57575
Release note (sql change): IMPORT and RESTORE now emit structured events
to the OPS channel. Refer to the generated documentation for details.