Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backupccl: no event log entries for restore and import #57575

Closed
knz opened this issue Dec 4, 2020 · 4 comments · Fixed by #62658
Closed

backupccl: no event log entries for restore and import #57575

knz opened this issue Dec 4, 2020 · 4 comments · Fixed by #62658
Assignees
Labels
A-logging In and around the logging infrastructure. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery

Comments

@knz
Copy link
Contributor

knz commented Dec 4, 2020

The bulk I/O operations should be reported in the event log. They are not currently.

cc @aaron-crl @piyush-singh

@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-logging In and around the logging infrastructure. labels Dec 4, 2020
@dt
Copy link
Member

dt commented Dec 9, 2020

Not including BACKUPs in event log is intentional -- BACKUPs are scheduled to run e.g. every 5min and should be non-events, just the steady, background state of your cluster. Filling eventlog with them seems likely to be spammy.

Similarly, EXPORT isn't an event any more than --format=csv -e "SELECT * ..." > myfile (it isn't even a job, since it isn't resumable -- it is literally just a SELECT query that writes to a file instead of a terminal).

IMPORT and RESTORE though both seem like they should log events, since they create objects which would usually also be events if run on their own.

@knz
Copy link
Contributor Author

knz commented Dec 9, 2020

ok that works for me

@dt dt changed the title backupccl: missing event log entries for backup/restore and import/export backupccl: no event log entries for restore and import Dec 9, 2020
@knz
Copy link
Contributor Author

knz commented Dec 22, 2020

Discussed with @aaron-crl : lower priority for the immediate CC free tier security goals, but we absolutely need this in v21.1 so that the Serverless release can use it.

@mwang1026
Copy link

We spoke about this wrt 21.1 and agreed that a single entry in event log specifying that RESTORE and IMPORT were run, and some reference to the directory / files that were imported/restored is sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-logging In and around the logging infrastructure. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants