Revert "util/log: more misc cleanups" #57178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts cockroachdb#57000, which introduced a race to crdb. Was able to reproduce it using make stressrace PKG=./pkg/sql/pgwire TESTS=TestConnResultsBufferSize The buggy commit in question appears to be ffd7f68. Release note: None
|
This change is |
adityamaru
approved these changes
Nov 26, 2020
|
bors r+ |
|
Build succeeded: |
This was referenced Nov 26, 2020
craig bot
pushed a commit
that referenced
this pull request
Nov 30, 2020
56395: sqlsmith: add schema-related operations r=jordanlewis a=jordanlewis User-defined schemas are now supported in sqlsmith. UDSs will be randomly generated, and new tables will be randomly included in the available UDSs. Queries will select from any table, including those inside of UDSs as well. Closes #54961. Release note: None 57222: Revert "Revert "util/log: more misc cleanups"" r=irfansharif a=knz Reverts #57178. This re-instates #57000, as it did not "introduce a race in crdb" The description in #57178 was incorrect - instead #57161 / #57162 merely outlined a bug in some tests, which remains to be fixed. This PR also includes a temporary workaround for said test bug. Fixes #57162. Fixes #57161 (presumably - although the symptoms there don't align). Co-authored-by: Jordan Lewis <[email protected]> Co-authored-by: Raphael 'kena' Poss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #57000, which introduced a race to crdb. Was able to
reproduce it using
make stressrace PKG=./pkg/sql/pgwire TESTS=TestConnResultsBufferSize
The buggy commit in question appears to be ffd7f68.
Touches #57162 and #57161.
Release note: None