sqlsmith: add schema-related operations #56395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User-defined schemas are now supported in sqlsmith. UDSs will be randomly generated, and new tables will be randomly included in the available UDSs. Queries will select from any table, including those inside of UDSs as well. Release note: None
|
This change is |
rafiss
approved these changes
Nov 9, 2020
| @@ -359,25 +392,10 @@ func (s *Smither) extractIndexes( | |||
| Direction: dir, | |||
| }) | |||
| } | |||
| row := s.db.QueryRow(fmt.Sprintf(` | |||
There was a problem hiding this comment.
we don't we need this 19.2 fallback logic any more?
There was a problem hiding this comment.
I don't think so - each roachtest is run on its branch now, I thought.
There was a problem hiding this comment.
ah yes, that was just changed in the beginning of november. so this lgtm
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-defined schemas are now supported in sqlsmith. UDSs will be
randomly generated, and new tables will be randomly included in the
available UDSs. Queries will select from any table, including those
inside of UDSs as well.
Closes #54961.
Release note: None