roachtest: update version map and fixtures #55445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
For release tracking issues:
|
jlinder
reviewed
Oct 12, 2020
| @@ -1171,8 +1171,8 @@ func PredecessorVersion(buildVersion version.Version) (string, error) { | |||
| // (see runVersionUpgrade). The same is true for adding a new key to this | |||
| // map. | |||
This was referenced Oct 12, 2020
Closed
celiala
force-pushed
the
bump-version-map
branch
2 times, most recently
from
15214bd to
9f79ed2
Compare
celiala
changed the title
|
Thanks @arulajmani and @irfansharif to helping me figure out how to generate the fixtures! 💯 This is RFAL, thank you! |
irfansharif
approved these changes
Oct 15, 2020
| "20.2": "20.1.6", | ||
| "20.1": "19.2.9", | ||
| "20.2": "20.1.7", | ||
| "20.1": "19.2.11", |
There was a problem hiding this comment.
I only see the fixtures in pkg/cmd/roachtest/fixtures/*/checkpoint-v20.1.tgz being updated, but it seems we're also bumping the version map for 19.2.11? If I've understood correctly, we'll need to generate fixtures for that too. We can do so by changing newV below for one run and copying those artifacts in.
There was a problem hiding this comment.
Ah, thank you! Done :)
| @@ -94,7 +94,7 @@ func runVersionUpgrade(ctx context.Context, t *test, c *cluster, buildVersion ve | |||
| // The version to create/update the fixture for. Must be released (i.e. | |||
| // can download it from the homepage); if that is not the case use the | |||
| // empty string which uses the local cockroach binary. | |||
| newV := "20.1.6" | |||
| newV := "20.1.7" | |||
This commit adds the recently released 19.2.11, and 20.1.7 to the version map in PredecessorVersion. Release note: None (testing change)
celiala
force-pushed
the
bump-version-map
branch
from
9f79ed2 to
4cef828
Compare
|
Thanks for the reviews and all the help! |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the recently released 19.2.11, and 20.1.7
to the version map in PredecessorVersion.
Release note: None (testing change)