Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: bump fixtures for 20.1 (to 20.1.6) #55253

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

irfansharif
Copy link
Contributor

And address fallout from roachprod changes around cluster
initialization (#51329). Touches #54761.

Release note: None

@irfansharif irfansharif requested review from tbg and arulajmani October 6, 2020 14:07
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@arulajmani arulajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping dig into this.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @arulajmani, @irfansharif, and @tbg)


pkg/cmd/roachtest/versionupgrade.go, line 523 at r1 (raw file):

for i in 1 2 3 4; do
  mkdir -p pkg/cmd/roachtest/fixtures/${i} && \
  mv artifacts/acceptance/version-upgrade/run_1/${i}.logs/checkpoint-*.tgz \

Could you update this to mv artifacts/acceptance/version-upgrade/run_1/logs/${i}.unredacted/checkpoint-*.tgz \ while we're here as well?

And address fallout from `roachprod` changes around cluster
initialization (cockroachdb#51329). Touches cockroachdb#54761.

Release note: None
@irfansharif irfansharif force-pushed the 201002.bump-fixtures branch from 0fa6285 to 33b371f Compare October 7, 2020 02:44
Copy link
Contributor Author

@irfansharif irfansharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @arulajmani and @tbg)


pkg/cmd/roachtest/versionupgrade.go, line 523 at r1 (raw file):

Previously, arulajmani (Arul Ajmani) wrote…

Could you update this to mv artifacts/acceptance/version-upgrade/run_1/logs/${i}.unredacted/checkpoint-*.tgz \ while we're here as well?

Done.

@irfansharif
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 7, 2020

Build succeeded:

@craig craig bot merged commit 272c280 into cockroachdb:master Oct 7, 2020
@irfansharif irfansharif deleted the 201002.bump-fixtures branch October 7, 2020 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants