release-20.2: bulkio: Propagate errors when executing schedule. #54581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use correct error object when checking for retryable errors. In addition, add a `FOR UPDATE` clause when picking up schedules to execute to reduce contention. Release Notes: None Release Justification: Bug fix; Incorrect handling of transaction errors resulted in scheduled jobs showing incorrect and confusing status message.
|
This change is |
|
LGTM but I think @dt is needed for sign off |
dt
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #54539.
/cc @cockroachdb/release
Fixes #54484
Informs #54484
Use correct error object when checking for retryable errors.
In addition, add a
FOR UPDATEclause when picking upschedules to execute to reduce contention.
Release Notes: None
Release Justification: Bug fix; Incorrect handling of transaction
errors resulted in scheduled jobs showing incorrect and confusing
status message.