bulkio: Propagate errors when executing schedule. #54539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
pbardea
approved these changes
Sep 17, 2020
Use correct error object when checking for retryable errors. In addition, add a `FOR UPDATE` clause when picking up schedules to execute to reduce contention. Release Notes: None Release Justification: Bug fix; Incorrect handling of transaction errors resulted in scheduled jobs showing incorrect and confusing status message.
miretskiy
force-pushed
the
schedule_txn
branch
from
d0b9f04 to
badf836
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #54484
Use correct error object when checking for retryable errors.
In addition, add a
FOR UPDATEclause when picking upschedules to execute to reduce contention.
Release Notes: None
Release Justification: Bug fix; Incorrect handling of transaction
errors resulted in scheduled jobs showing incorrect and confusing
status message.