Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFCs: update geospatial RFC #52958

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Conversation

otan
Copy link
Contributor

@otan otan commented Aug 18, 2020

Update geospatial RFC to be in line with updated offerings and commands.

Release note: None

@otan otan requested review from sumeerbhola and a team August 18, 2020 02:05
@otan otan requested a review from a team as a code owner August 18, 2020 02:05
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @otan)


docs/RFCS/20200421_geospatial.md, line 606 at r1 (raw file):

echo "IMPORT PGDUMP 'nodelocal://0/import.sql" cockroach sql·

is this missing a pipe?

Update geospatial RFC to be in line with updated offerings and commands.

Release note: None
Copy link
Contributor Author

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @sumeerbhola)


docs/RFCS/20200421_geospatial.md, line 606 at r1 (raw file):

Previously, sumeerbhola wrote…
echo "IMPORT PGDUMP 'nodelocal://0/import.sql" cockroach sql·

is this missing a pipe?

Done.

@otan
Copy link
Contributor Author

otan commented Aug 18, 2020

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 18, 2020

Build succeeded:

@craig craig bot merged commit f41ff14 into cockroachdb:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants