release-19.2: sql/pgwire: avoid new memory allocation in writeTextDatum(Date) #41426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3dfd6cb introduced a performance regression in the speed of encoding Date datums to their text representation. This commit partially avoids the regression. ``` name old time/op new time/op delta WriteTextDate-16 446ns ± 4% 318ns ± 1% -28.75% (p=0.000 n=10+9) ``` Release justification: Avoids performance regression. Release note: None
|
This change is |
maddyblue
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #41403.
/cc @cockroachdb/release
3dfd6cb introduced a performance regression in the speed of encoding
Date datums to their text representation. This commit partially avoids
the regression.
Release justification: Avoids performance regression.
Release note: None