sql/pgwire: avoid new memory allocation in writeTextDatum(Date) #41403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3dfd6cb introduced a performance regression in the speed of encoding Date datums to their text representation. This commit partially avoids the regression. ``` name old time/op new time/op delta WriteTextDate-16 446ns ± 4% 318ns ± 1% -28.75% (p=0.000 n=10+9) ``` Release justification: Avoids performance regression. Release note: None
|
This change is |
|
The overwhelming majority of the remaining time is spent in
Unless we want to get very manual and do something like |
|
Also good catch. |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 7, 2019
41399: sql/pgwire: fix BenchmarkWriteBinary{Int,Float} r=nvanbenschoten a=nvanbenschoten
Before this fix, the benchmark was always hitting an error because it was
forgetting to pass an OID `writeBuffer.writeBinaryDatum`. This commit fixes
the benchmark and checks the error to make sure we catch bugs like this in
the future.
Release justification: Testing only.
Release note: None
41400: disable release justification hint and lint. r=RaduBerinde a=RaduBerinde
This effectively disables commit feeaf62.
The functionality is moved behind flags so it can easily be revived
for next release.
Release justification: how ironic.
Release note: None
41403: sql/pgwire: avoid new memory allocation in writeTextDatum(Date) r=nvanbenschoten a=nvanbenschoten
3dfd6cb introduced a performance regression in the speed of encoding
Date datums to their text representation. This commit partially avoids
the regression.
```
name old time/op new time/op delta
WriteTextDate-16 446ns ± 4% 318ns ± 1% -28.75% (p=0.000 n=10+9)
```
Release justification: Avoids performance regression.
Release note: None
41406: Revert "Merge #41307" r=andreimatei a=andreimatei
This reverts commit 1c99165, reversing
changes made to e6e9161.
Somehow #41307 broke some Jepsen tests. Reversing while I investigate.
Fixes #41376
Fixes #41364
Fixes #41363
Fixes #41362
Release justification: broke Jepsen
Release note: None
Co-authored-by: Nathan VanBenschoten <[email protected]>
Co-authored-by: Radu Berinde <[email protected]>
Co-authored-by: Andrei Matei <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3dfd6cb introduced a performance regression in the speed of encoding
Date datums to their text representation. This commit partially avoids
the regression.
Release justification: Avoids performance regression.
Release note: None