engine: Rename the magic slice assembly file #38021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assembly files are supposed to be run through the preprocessor only when they end in a captial .S. On the linux build, it appears to run through the preprocessor anyway, but this is not the case for the windows build (note that our windows binary is cross-compiled from linux; this is not about case-insensitivity of the windows filesystem). The windows build is broken when this file has a lowercase .s. Renames that consist only of case changes are poorly supported by git and other tools, so also change the base name of the file. Some tools support a .sx extension for a less-subtle version of this distinction, but go does not. Release note: None
|
This change is |
|
LGTM. |
|
bors r=jordanlewis
Oh, it's not going through the preprocessor but the assembler (at least this assembler) recognizes both |
craig bot
pushed a commit
that referenced
this pull request
Jun 4, 2019
38021: engine: Rename the magic slice assembly file r=jordanlewis a=bdarnell Assembly files are supposed to be run through the preprocessor only when they end in a captial .S. On the linux build, it appears to run through the preprocessor anyway, but this is not the case for the windows build (note that our windows binary is cross-compiled from linux; this is not about case-insensitivity of the windows filesystem). The windows build is broken when this file has a lowercase .s. Renames that consist only of case changes are poorly supported by git and other tools, so also change the base name of the file. Some tools support a .sx extension for a less-subtle version of this distinction, but go does not. Release note: None Co-authored-by: Ben Darnell <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assembly files are supposed to be run through the preprocessor only
when they end in a captial .S. On the linux build, it appears to run
through the preprocessor anyway, but this is not the case for the
windows build (note that our windows binary is cross-compiled from
linux; this is not about case-insensitivity of the windows
filesystem). The windows build is broken when this file has a
lowercase .s.
Renames that consist only of case changes are poorly supported by git
and other tools, so also change the base name of the file. Some tools
support a .sx extension for a less-subtle version of this distinction,
but go does not.
Release note: None