Skip to content

Commit

Permalink
Merge #38021
Browse files Browse the repository at this point in the history
38021: engine: Rename the magic slice assembly file r=jordanlewis a=bdarnell

Assembly files are supposed to be run through the preprocessor only
when they end in a captial .S. On the linux build, it appears to run
through the preprocessor anyway, but this is not the case for the
windows build (note that our windows binary is cross-compiled from
linux; this is not about case-insensitivity of the windows
filesystem). The windows build is broken when this file has a
lowercase .s.

Renames that consist only of case changes are poorly supported by git
and other tools, so also change the base name of the file. Some tools
support a .sx extension for a less-subtle version of this distinction,
but go does not.

Release note: None

Co-authored-by: Ben Darnell <[email protected]>
  • Loading branch information
craig[bot] and bdarnell committed Jun 4, 2019
2 parents 9521979 + 416f500 commit 53fada8
Showing 1 changed file with 0 additions and 0 deletions.
File renamed without changes.

0 comments on commit 53fada8

Please sign in to comment.