ui: fix statements page crash #28108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 31, 2018 14:26
That way, you can pass a function to render your content which will only get run if the data is finished loading. Thus, your content-rendering function can assume that the data is loaded, which simplifies it. It would be nice to migrate all usages at once, but we never seem to find time to work on the loading component, and this moves the ball forward a bit. Release note: None
Use new render prop on Loading component so `renderStatements` is only called when data is finished loading. Release note (admin ui change): fix bug in which statements page blanks out after it reloads itself after a few minutes.
|
This change is |
Contributes to: cockroachdb#24011 Release note: None
|
Your commits LGTM, do you want to take a look at mine? |
|
Looks good; thanks for doing the refactor! Next up, removing the spinner image prop… That was in your "more magical loading component" PR, right? bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 1, 2018
28108: ui: fix statements page crash r=vilterp a=vilterp Release note (admin ui change): fix bug in which statements page blanks out after it reloads itself after a few minutes. Includes introduction of `render` prop to `Loading` component. I don't have time for a major discussion and refactor right now, but I also can't stomach yet another stupid bug caused by `Loading` being the way it is right now. Co-authored-by: Pete Vilter <[email protected]> Co-authored-by: Andrew Couch <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note (admin ui change): fix bug in which statements page blanks out after it reloads itself after a few minutes.
Includes introduction of
renderprop toLoadingcomponent. I don't have time for a major discussion and refactor right now, but I also can't stomach yet another stupid bug caused byLoadingbeing the way it is right now.