Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: consistent & useful loading indicators [460] #24011

Closed
1 of 2 tasks
nstewart opened this issue Mar 19, 2018 · 2 comments
Closed
1 of 2 tasks

ui: consistent & useful loading indicators [460] #24011

nstewart opened this issue Mar 19, 2018 · 2 comments
Assignees
@couchand
Labels
A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Comments

@nstewart
Copy link
Contributor

nstewart commented Mar 19, 2018 •
edited by piyush-singh
Loading

image

  • Page shouldn't say no results when in reality its loading
  • Page loses highlighted database icon in the left-hand nav so it's not clear where you came from
@couchand
Copy link
Contributor

The second point is covered in #24069. I'm surprised to see that there's not already an issue describing the inconsistent/annoying loading states across all pages. The closest I can find is #19347, though that is restricted to the databases page (which has it's own issues with data loading). So I'm repurposing this issue to stand in for regularizing our loading states across all pages.

@couchand couchand changed the title ui: Database -> tables -> table permalink usability updates ui: consistent & useful loading indicators Mar 20, 2018
@couchand couchand added this to the 2.1 milestone Mar 20, 2018
@couchand couchand added the C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. label Mar 20, 2018
@vilterp
Copy link
Contributor

vilterp commented Mar 20, 2018 •
edited
Loading

Agree that a consistent pattern for data loading (and error) states deserves its own issue. #1 highest-value refactor we could do to the UI, IMO.

@piyush-singh piyush-singh changed the title ui: consistent & useful loading indicators ui: consistent & useful loading indicators [460] Apr 9, 2018
@vilterp vilterp mentioned this issue Apr 17, 2018
Merged
@couchand couchand self-assigned this Apr 23, 2018
@couchand couchand mentioned this issue Apr 23, 2018
Closed
@couchand couchand added the A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category. label Apr 24, 2018
craig bot pushed a commit that referenced this issue Jun 14, 2018
Merge #24855
0673874 
24855: ui: add data distribution debug page (aka replica matrix) r=vilterp a=vilterp

![image](https://user-images.githubusercontent.com/7341/41315292-0f7d284a-6e5d-11e8-81cb-cacd978cc519.png)

Split off from #20500, which had some CR comments from four months ago. Many have been addressed, but need to comb through again.

Note: if one of its API calls returns an error, it will display the spinner forever. Sadly, the cluster viz has the same problem (as well as many other pages, probably). Kind of want to address this with some changes to `Loader` as part of #24011, but maybe should just address it here.

Co-authored-by: Pete Vilter <[email protected]>
couchand added a commit to couchand/cockroach that referenced this issue Aug 1, 2018
@couchand
ui: convert all uses of Loading to render prop
85f6ca6 
Contributes to: cockroachdb#24011
Release note: None
@couchand couchand mentioned this issue Aug 1, 2018
Closed
couchand added a commit to vilterp/cockroach that referenced this issue Aug 1, 2018
@couchand
ui: convert all uses of Loading to render prop
03bfed9 
Contributes to: cockroachdb#24011
Release note: None
@couchand couchand modified the milestones: 2.1, 2.2 Oct 1, 2018
@petermattis petermattis removed this from the 2.2 milestone Oct 5, 2018
@celiala celiala mentioned this issue Nov 19, 2018
Merged
celiala added a commit to celiala/cockroach that referenced this issue Nov 21, 2018
@celiala
ui: render errors in Loading component
89687a8 
Previously, data fetching errors were not being consistently surfaced to
the user. This commit updates all existing uses of the Loading component
to surface these errors:

 - Some parent components render data from multiple sources,
   potentially having multiple errors to show the user. This commit also
   extends the Loading component to handle multiple errors.
 - The Certificates page had custom loading logic. This commit replaces
   logic with Loading component.

Also in this commit is some minor cleanup (copy, layout).

Fixes: cockroachdb#24011

Release note (admin ui change): This commit wires up data errors to all
existing uses of the Loading component. Previously, data errors weren't
consistently surfaced.
celiala added a commit to celiala/cockroach that referenced this issue Nov 21, 2018
@celiala
ui: render errors in Loading component
3a08407 
Previously, data fetching errors were not being consistently surfaced to
the user. This commit updates all existing uses of the Loading component
to surface these errors:

 - Some parent components render data from multiple sources,
   potentially having multiple errors to show the user. This commit also
   extends the Loading component to handle multiple errors.
 - The Certificates page had custom loading logic. This commit replaces
   logic with Loading component.

Also in this commit is some minor cleanup (copy, layout).

Fixes: cockroachdb#24011

Release note (admin ui change): This commit wires up data errors to all
existing uses of the Loading component. Previously, data errors weren't
consistently surfaced.
craig bot pushed a commit that referenced this issue Nov 21, 2018
@celiala
Merge #32464
910739d 
32464: ui: render errors in Loading component r=couchand a=celiala

Previously, data fetching errors were not being consistently surfaced to
the user. This commit updates all existing uses of the Loading component
to surface these errors:

 - Some parent components renders data from multiple sources,
   potentially having multiple errors to show the user. This commit also
   extends the Loading component to handle multiple errors.
 - The Certificates page had custom loading logic. This commit replaces
   logic with Loading component.

Also in this commit is some minor cleanup (copy, layout).

Fixes: #24011

Release note (admin ui change): This commit wires up data errors to all
existing uses of the Loading component. Previously, data errors weren't
consistently surfaced.

Co-authored-by: Pete Vilter <[email protected]>
Co-authored-by: Celia La <[email protected]>
@craig craig bot closed this as completed in #32464 Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@couchand couchand

Labels
A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vilterp @couchand @nstewart @petermattis