roachtest: make the clock jump and clock monotonic tests subtests #25433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Previously, each of the 7 clock tests took ~200s to run (~1400s total). Now, all 7 take ~400s to run. Review status: 0 of 4 files reviewed at latest revision, all discussions resolved. pkg/cmd/roachtest/registry.go, line 26 at r1 (raw file):
Sorting is hard. Comments from Reviewable |
petermattis
force-pushed
the
pmattis/roachtest-subtests2
branch
2 times, most recently
from
5cb75f4 to
1ec7c8b
Compare
Fixes cockroachdb#25432 Release note: None
Fixes cockroachdb#25449 Release note: None
petermattis
force-pushed
the
pmattis/roachtest-subtests2
branch
from
41fc533 to
25361e8
Compare
|
Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion. Comments from Reviewable |
|
bors r=bdarnell |
craig bot
pushed a commit
that referenced
this pull request
May 14, 2018
25433: roachtest: make the clock jump and clock monotonic tests subtests r=bdarnell a=petermattis Fixes #25432 Release note: None Co-authored-by: Peter Mattis <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25432
Release note: None