Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: use subtests where useful #25432

Closed
petermattis opened this issue May 11, 2018 · 0 comments
Closed

roachtest: use subtests where useful #25432

petermattis opened this issue May 11, 2018 · 0 comments
Assignees
@petermattis
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Milestone
2.1

Comments

@petermattis
Copy link
Collaborator

#25408 added support for subtests which share a cluster. We should audit the existing set of tests for opportunities to use subtests to speed up running roachtests. For example, the clockjump tests look like they could all use the same cluster. Ditto for the clockmonotonic tests.
@petermattis petermattis added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. A-roachtest labels May 11, 2018
@petermattis petermattis added this to the 2.1 milestone May 11, 2018
@petermattis petermattis self-assigned this May 11, 2018
petermattis added a commit to petermattis/cockroach that referenced this issue May 11, 2018
@petermattis
roachtest: make the clock jump and clock monotonic tests subtests
3feb61c 
Fixes cockroachdb#25432

Release note: None
@petermattis petermattis mentioned this issue May 11, 2018
Merged
petermattis added a commit to petermattis/cockroach that referenced this issue May 12, 2018
@petermattis
roachtest: make the clock jump and clock monotonic tests subtests
ec1abbe 
Fixes cockroachdb#25432

Release note: None
craig bot pushed a commit that referenced this issue May 14, 2018
@petermattis
Merge #25433
92fdda1 
25433: roachtest: make the clock jump and clock monotonic tests subtests r=bdarnell a=petermattis

Fixes #25432

Release note: None

Co-authored-by: Peter Mattis <[email protected]>
@craig craig bot closed this as completed in #25433 May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermattis petermattis

Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
1 participant
@petermattis