Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Revert change to dialer (and test skips) #22620

Merged
merged 2 commits into from
Feb 13, 2018

Conversation

bdarnell
Copy link
Contributor

This change made several tests flaky (and its effects are not limited to these tests). Revert it until I can figure out what's going on.

@bdarnell bdarnell requested a review from a team as a code owner February 12, 2018 23:47
@bdarnell bdarnell requested a review from a team February 12, 2018 23:47
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@nvanbenschoten nvanbenschoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plan to fix this by the code freeze?

@bdarnell
Copy link
Contributor Author

Based on my investigation so far it looks like this change caused some strange behavior in the lease/liveness machinery. I think it may be a bug in error handling in that code (it's getting an ambiguous error where it may not have before), but it's hard to tell exactly what's going on. I'm going to spend some more time on this but I don't know if I'll be able to figure it out before the freeze.

@bdarnell
Copy link
Contributor Author

I've removed the "unskip TestVersionUpgrade" change from this PR - I had three consecutive acceptance test timeouts with it, so apparently that test was not made flaky by the change being reverted here.

@bdarnell bdarnell merged commit b551b40 into cockroachdb:master Feb 13, 2018
@bdarnell bdarnell deleted the revert-grpc branch February 13, 2018 02:42
@bdarnell
Copy link
Contributor Author

Note that since the TestVersionUpgrade failures appear to be unrelated, I'm more optimistic that I'll be able to re-enable this (and the CLI quit test which is definitely related) before the freeze. But we need to figure out what's going on with TestVersionUpgrade before I can do so with confidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants