Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acceptance: TestVersionUpgrade times out #22581

Closed
benesch opened this issue Feb 12, 2018 · 7 comments
Closed

acceptance: TestVersionUpgrade times out #22581

benesch opened this issue Feb 12, 2018 · 7 comments

Comments

@benesch
Copy link
Contributor

benesch commented Feb 12, 2018

https://gist.github.com/benesch/e652cc39b600430353d24e7a3f796ed1
benesch added a commit to benesch/cockroach that referenced this issue Feb 12, 2018
@benesch
acceptance: skip flaky VersionUpgradeTest
9ab9926 
Investigation is tracked in cockroachdb#22581.

Release note: None
@benesch benesch mentioned this issue Feb 12, 2018
Merged
@benesch
Copy link
Contributor Author

benesch commented Feb 12, 2018

Seems related to #22518.

/cc @bdarnell

nvanbenschoten added a commit to nvanbenschoten/cockroach that referenced this issue Feb 12, 2018
@nvanbenschoten
[DNM] acceptance: upgrade to max unstable version in TestVersionUpgrade
8bb26b5 
Blocked on cockroachdb#22581.

Release note: None
@nvanbenschoten nvanbenschoten mentioned this issue Feb 12, 2018
Closed
@bdarnell
Copy link
Contributor

Maybe not - my revert of #22518 (#22620) is also experiencing hangs in the acceptance tests.

@bdarnell
Copy link
Contributor

#22620 had three CI hangs in a row when I un-skipped this test, so this appears to be unrelated to #22518.

@bdarnell
Copy link
Contributor

Looking at the teamcity logs, this became flaky after #22487 went in (the other merges around this time seem unlikely to be an issue; they're mostly affecting the UI and optimizer). CC @nvanbenschoten

This test has rotted - it tests an upgrade from 1.0.5 to master without going through 1.1. It should be failing; the question is why it is flaky rather than failing every time.

@bdarnell bdarnell mentioned this issue Feb 13, 2018
Closed
@nvanbenschoten
Copy link
Member

Closing now that #22637 is merged. We can re-open if we see this fail again.

@nvanbenschoten
Copy link
Member

I'm going to re-enable this test and look into improving it with suggestions from #15851 (comment).

@benesch
Copy link
Contributor Author

benesch commented Feb 13, 2018

Heads up that v1.1.0 is busted; it reports its version as v1.0-3. You may want to start with v1.1.1 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bdarnell @benesch @nvanbenschoten