Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2.13-rc: changefeedccl: add parallel io metrics #132491

Conversation

wenyihu6
Copy link
Contributor

@wenyihu6 wenyihu6 commented Oct 11, 2024

Backport 1/1 commits from #115785.

/cc @cockroachdb/release


This change adds metrics to improve the observability of contention in
the batching webhook and pubsub sinks.

Previously, there were no metrics to count the number of pending and in-flight keys,
so this change adds changefeed.parallel_io_pending_keys and
changefeed.parallel_io_result_queue_nanos to measure them respectively.

This change also adds changefeed.parallel_io_result_queue_nanos to measure
the time which results from the sink must wait in a queue before the changefeed
acks them.

Release note: None


Release justification: low risk observability improvement

Copy link

blathers-crl bot commented Oct 11, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 11, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

This change adds metrics to improve the observability of contention in
the batching webhook and pubsub sinks.

Previously, there were no metrics to count the number of pending and in-flight keys,
so this change adds `changefeed.parallel_io_pending_keys` and
`changefeed.parallel_io_result_queue_nanos` to measure them respectively.

This change also adds `changefeed.parallel_io_result_queue_nanos` to measure
the time which results from the sink must wait in a queue before the changefeed
acks them.

Release note: None
Closes: cockroachdb#114140
Epic: None

# Conflicts:
#	pkg/ccl/changefeedccl/metrics.go
#	pkg/ccl/changefeedccl/telemetry.go
@wenyihu6 wenyihu6 force-pushed the backport23.2.13-rc-115785 branch from 6897975 to 6de39cc Compare October 11, 2024 21:15
@wenyihu6 wenyihu6 marked this pull request as ready for review October 11, 2024 21:17
@wenyihu6 wenyihu6 requested a review from a team as a code owner October 11, 2024 21:17
@wenyihu6 wenyihu6 requested review from andyyang890 and rharding6373 and removed request for a team and andyyang890 October 11, 2024 21:17
Copy link
Collaborator

@rharding6373 rharding6373 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rharding6373 rharding6373 merged commit f00c152 into cockroachdb:release-23.2.13-rc Oct 11, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants