changefeedccl: add parallel io metrics #115785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jayshrivastava
force-pushed
the
pubsub-obs-inflight
branch
from
c54b31b to
97a9b56
Compare
jayshrivastava
changed the title
jayshrivastava
force-pushed
the
pubsub-obs-inflight
branch
2 times, most recently
from
81467d3 to
abeaf47
Compare
jayshrivastava
requested review from
miretskiy
and removed request for
a team
miretskiy
approved these changes
Dec 11, 2023
jayshrivastava
force-pushed
the
pubsub-obs-inflight
branch
4 times, most recently
from
11a6b32 to
4ca6d2d
Compare
This change adds metrics to improve the observability of contention in the batching webhook and pubsub sinks. Previously, there were no metrics to count the number of pending and in-flight keys, so this change adds `changefeed.parallel_io_pending_keys` and `changefeed.parallel_io_result_queue_nanos` to measure them respectively. This change also adds `changefeed.parallel_io_result_queue_nanos` to measure the time which results from the sink must wait in a queue before the changefeed acks them. Release note: None Closes: cockroachdb#114140 Epic: None
jayshrivastava
force-pushed
the
pubsub-obs-inflight
branch
from
4ca6d2d to
b90e6fe
Compare
|
bors r+ |
|
Build succeeded: |
|
blathers backport 23.2 |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from b90e6fe to blathers/backport-release-23.2-115785: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds metrics to improve the observability of contention in
the batching webhook and pubsub sinks.
Previously, there were no metrics to count the number of pending and in-flight keys,
so this change adds
changefeed.parallel_io_pending_keysandchangefeed.parallel_io_result_queue_nanosto measure them respectively.This change also adds
changefeed.parallel_io_result_queue_nanosto measurethe time which results from the sink must wait in a queue before the changefeed
acks them.
Release note: None