release-24.1: sql: override StmtTimeout to 0 for sessionless IE #129515
+35
−88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #129489.
/cc @cockroachdb/release
For queries issued by a sessionless internal executor,
we inherit values from cluster settings. This means
that setting a cluster-wide statement timeout will
impact processes that use a sessionless internal
executor: background jobs, db console, cloud sql
shell, etc. This behavior doesn't make sense in most
cases; so, this patch will override the statement timeout
to 0s (i.e. none).
For the cloud sql shell, this change makes sense as there
is a default payload request timeout applied to these
queries (5s).
Fixes: #126261
Release note (bug fix): Internally issued queries that are not
initiated within a SQL session no longer respect a statement timeout.
This includes: background jobs, queries issued by the db
console that perform introspection, and the cloud sql shell.
Release justification: high-prio fix for support customer