-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: override StmtTimeout to 0 for sessionless IE #129489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
64c2e9d
to
1aa72aa
Compare
TFTR! ('-')7 bors r=rafiss |
Merge conflict. |
This reverts commit 178e453.
For queries issued by a sessionless internal executor, we inherit values from cluster settings. This means that setting a cluster-wide statement timeout will impact processes that use a sessionless internal executor: background jobs, db console, cloud sql shell, etc. This behavior doesn't make sense in most cases; so, this patch will override the statement timeout to 0s (i.e. none). For the cloud sql shell, this change makes sense as there is a default payload request timeout applied to these queries (5s). Fixes: cockroachdb#126261 Release note (bug fix): Internally issued queries that are not initiated within a SQL session no longer respect a statement timeout. This includes: background jobs, queries issued by the db console that perform introspection, and the cloud sql shell.
1aa72aa
to
8f01b63
Compare
bors r=rafiss |
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #126261: branch-release-24.2. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from a53bf7a to blathers/backport-release-23.2-129489: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.2.x failed. See errors above. error creating merge commit from a53bf7a to blathers/backport-release-24.1-129489: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 24.1.x failed. See errors above. error creating merge commit from a53bf7a to blathers/backport-release-24.2-129489: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 24.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
For queries issued by a sessionless internal executor,
we inherit values from cluster settings. This means
that setting a cluster-wide statement timeout will
impact processes that use a sessionless internal
executor: background jobs, db console, cloud sql
shell, etc. This behavior doesn't make sense in most
cases; so, this patch will override the statement timeout
to 0s (i.e. none).
For the cloud sql shell, this change makes sense as there
is a default payload request timeout applied to these
queries (5s).
Fixes: #126261
Release note (bug fix): Internally issued queries that are not
initiated within a SQL session no longer respect a statement timeout.
This includes: background jobs, queries issued by the db
console that perform introspection, and the cloud sql shell.