ui: improve db page nodes/regions query

[xinhaoz]

This commit rewrites the query to fetch node and region information for a db
in the databases page in db-console. The runtime of the query is improved
by removing the expressions used to extract the region information in the
replica_locality column of the ranges table since this field was not used
in the client.

The function createMockDatabaseRangesForTable in fakeApi.ts is also
deleted as it has no callers.

Part of: #114690

Release note: None

---

https://www.loom.com/share/cec82ea6c26849e28cfea31d66fdc719

[cockroach-teamcity]

This change is 

[dhartunian]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @abarganier and @xinhaoz)

---

pkg/ui/workspaces/cluster-ui/src/databases/combiners.ts line 82 at r2 (raw file):

  const dbStats = dbDetails?.data?.results.stats;
  // TODO #118957 (xinhaoz) Use store id to regions mapping.
  const nodes = dbStats?.replicaData.storeIDs || [];

can this variable be stores? or is that work that will be in a follow up PR? The way this reads suggests that if store and node IDs don't match the code won't work.

[xinhaoz]

pkg/ui/workspaces/cluster-ui/src/databases/combiners.ts line 82 at r2 (raw file):

Previously, dhartunian (David Hartunian) wrote…

can this variable be stores? or is that work that will be in a follow up PR? The way this reads suggests that if store and node IDs don't match the code won't work.

Was planning on renaming it when resolving #118957, but I can change it now, too (have to repush anyways to resolve a test).

[dhartunian]

Reviewed 2 of 4 files at r1, 3 of 3 files at r3, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @abarganier and @xinhaoz)

---

pkg/ui/workspaces/cluster-ui/src/api/databaseDetailsApi.ts line 370 at r3 (raw file):

          `
            SELECT array_agg(DISTINCT unnested) AS store_ids
            FROM [SHOW RANGES FROM DATABASE %1], unnest(replicas) AS unnested

nit: can you call this something more specific like unnested_store_ids? Reading DISTINCT unnested in the SELECT is confusing.

---

pkg/ui/workspaces/cluster-ui/src/api/databaseDetailsApi.ts line 383 at r3 (raw file):

        resp.stats.replicaData.error = txn_result.error;
      }
      resp.stats.replicaData.storeIDs = txn_result?.rows[0]?.store_ids ?? [];

should we be returning from the error clause? and seeing .storeIDs to empty there? Can we avoid some of the ? in that case and assume we have some data?

[xinhaoz]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @abarganier and @dhartunian)

---

pkg/ui/workspaces/cluster-ui/src/api/databaseDetailsApi.ts line 370 at r3 (raw file):

Previously, dhartunian (David Hartunian) wrote…

nit: can you call this something more specific like unnested_store_ids? Reading DISTINCT unnested in the SELECT is confusing.

Done.

---

pkg/ui/workspaces/cluster-ui/src/api/databaseDetailsApi.ts line 383 at r3 (raw file):

Previously, dhartunian (David Hartunian) wrote…

should we be returning from the error clause? and seeing .storeIDs to empty there? Can we avoid some of the ? in that case and assume we have some data?

I kept the previous behaviour of not returning on error since the error could be something where we can still show partial results (e.g. max size exceeded).

[dhartunian]

Reviewed all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @abarganier)

[xinhaoz]

tftr!
bors r+

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from bcf2d35 to blathers/backport-release-23.1-118904: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}