ui: db pages are using store ids as node ids for regions mapping

[xinhaoz]

The databases pages display region information for databases and tables using a nodeId -> region map. The value currently being used to lookup region information is not the node id, but the store id. This is because the db details api returns the store ids replicas are located on, not the node ids. This bug likely remained undetected for a while since lots of clusters have 1-1 mapping from store id to node id but store ids and node ids cannot be used interchangeably. Clusters with multiple stores per node will see bugs where missing/incorrect region information is being reported.

See this comment for the table used to return db details on stores being used by the db -

cockroach/pkg/sql/crdb_internal.go

Line 4451 in 43072c2

// NB 2: All the values in the `*replicas` columns correspond to store IDs.

And here in the UI, where we use node id -> region mappings with the store id -

cockroach/pkg/ui/workspaces/cluster-ui/src/databases/combiners.ts

Lines 81 to 86 in 7f8d242

	const nodes = dbStats?.replicaData.replicas || [];
	const nodesByRegionString = getNodesByRegionString(
	nodes,
	nodeRegionsByID,
	isTenant,
	);

We can either create a store ids -> region map or map each store id to their node and use the existing map. Each node status response should contain the node's stores.

Jira issue: CRDB-35974