cli: remove t field from TestCLI usage
#117137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, these tests fail in CI with a nil pointer at runtime when we call `c.t.Fail` when an error is produced. This change removes the sharing of the `t` variable with `TestCLI` since it seems to result in a conflict between the outer test code and what runs inside `RunWithCapture`. I was unable to reproduce the error locally and do not have further clues. My hope is that, the simplified error handling will surface the actual error in CI instead of the continued nil pointer exception. Resolves: cockroachdb#116228 Epic: None Release note: None
|
This change is |
abarganier
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained
|
bors r=abarganier |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, these tests fail in CI with a nil pointer at runtime when we call
c.t.Failwhen an error is produced.This change removes the sharing of the
tvariable withTestCLIsince it seems to result in a conflict between the outer test code and what runs insideRunWithCapture.I was unable to reproduce the error locally and do not have further clues. My hope is that, the simplified error handling will surface the actual error in CI instead of the continued nil pointer exception.
Resolves: #116228
Epic: None
Release note: None