Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: TestUnavailableZip failed #116228

Closed
cockroach-teamcity opened this issue Dec 12, 2023 · 4 comments · Fixed by #117137
Closed

cli: TestUnavailableZip failed #116228

cockroach-teamcity opened this issue Dec 12, 2023 · 4 comments · Fixed by #117137
Assignees
@dhartunian
Labels
A-observability-inf branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-1 Issues/test failures with a fix SLA of 1 month release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Milestone
24.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Dec 12, 2023 •
edited by cockroach-jira-scripts
Loading

cli.TestUnavailableZip failed with artifacts on master @ 96374f0c0c4758c93403631ce49c1c7bc93ef42e:

=== RUN   TestUnavailableZip
    test_log_scope.go:170: test logs captured to: /artifacts/tmp/_tmp/2d3a1724ffe0f36d7c3bd890e201d037/logTestUnavailableZip2926621408
[debug --host=127.0.0.1:43879 --insecure=true zip --concurrency=1 --cpu-profile-duration=0 /dev/null --timeout=.5s]
    zip_test.go:497: -- test log scope end --
--- FAIL: TestUnavailableZip (76.11s)
=== RUN   TestUnavailableZip/server_2
[debug --host=127.217.235.249:34023 --insecure=true zip --concurrency=1 --cpu-profile-duration=0 /dev/null --timeout=.5s]
    testutils.go:122: panic: runtime error: invalid memory address or nil pointer dereference
test logs left over in: /artifacts/tmp/_tmp/2d3a1724ffe0f36d7c3bd890e201d037/logTestUnavailableZip2926621408
    --- FAIL: TestUnavailableZip/server_2 (38.33s)
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/obs-inf-prs @cockroachdb/server

This test on roachdash | Improve this report!

Jira issue: CRDB-34527
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-observability-inf labels Dec 12, 2023
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone Dec 12, 2023
@dhartunian dhartunian self-assigned this Dec 12, 2023
@dhartunian dhartunian added the P-1 Issues/test failures with a fix SLA of 1 month label Dec 12, 2023
@cockroach-teamcity
Copy link
Member Author

cli.TestUnavailableZip failed with artifacts on master @ 52329bc384068b9ea3e0c0e1100397f537dd2b89:

=== RUN   TestUnavailableZip
    test_log_scope.go:170: test logs captured to: /artifacts/tmp/_tmp/2d3a1724ffe0f36d7c3bd890e201d037/logTestUnavailableZip1849997931
    zip_test.go:497: -- test log scope end --
--- FAIL: TestUnavailableZip (76.14s)
=== RUN   TestUnavailableZip/server_2
[debug --host=127.84.182.11:34193 --insecure=true zip --concurrency=1 --cpu-profile-duration=0 /dev/null --timeout=.5s]
    testutils.go:122: panic: runtime error: invalid memory address or nil pointer dereference
test logs left over in: /artifacts/tmp/_tmp/2d3a1724ffe0f36d7c3bd890e201d037/logTestUnavailableZip1849997931
    --- FAIL: TestUnavailableZip/server_2 (38.82s)
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

cli.TestUnavailableZip failed with artifacts on master @ 512fc0e95bbd6690740c6e77b4efce6a4edd58b2:

=== RUN   TestUnavailableZip
    test_log_scope.go:170: test logs captured to: /artifacts/tmp/_tmp/2d3a1724ffe0f36d7c3bd890e201d037/logTestUnavailableZip3739867215
    zip_test.go:497: -- test log scope end --
--- FAIL: TestUnavailableZip (76.29s)
=== RUN   TestUnavailableZip/server_1
[debug --host=127.0.0.1:35915 --insecure=true zip --concurrency=1 --cpu-profile-duration=0 /dev/null --timeout=.5s]
[debug --host=127.225.206.203:36453 --insecure=true zip --concurrency=1 --cpu-profile-duration=0 /dev/null --timeout=.5s]
    testutils.go:122: panic: runtime error: invalid memory address or nil pointer dereference
    --- FAIL: TestUnavailableZip/server_1 (31.74s)
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

cli.TestUnavailableZip failed with artifacts on master @ 6556ee673bfc8938511981ea7892d00d75448cfa:

=== RUN   TestUnavailableZip
    test_log_scope.go:170: test logs captured to: /artifacts/tmp/_tmp/2d3a1724ffe0f36d7c3bd890e201d037/logTestUnavailableZip2550299971
[debug --host=127.0.0.1:34527 --insecure=true zip --concurrency=1 --cpu-profile-duration=0 /dev/null --timeout=.5s]
    zip_test.go:497: -- test log scope end --
--- FAIL: TestUnavailableZip (74.52s)
=== RUN   TestUnavailableZip/server_2
[debug --host=127.185.28.49:46545 --insecure=true zip --concurrency=1 --cpu-profile-duration=0 /dev/null --timeout=.5s]
    testutils.go:122: panic: runtime error: invalid memory address or nil pointer dereference
    --- FAIL: TestUnavailableZip/server_2 (38.35s)
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

cli.TestUnavailableZip failed on master @ d2d974202781321ddb4fb1115c68fe7566ab9d06:

=== RUN   TestUnavailableZip
    test_log_scope.go:170: test logs captured to: outputs.zip/logTestUnavailableZip469557031
    zip_test.go:497: -- test log scope end --
test logs left over in: outputs.zip/logTestUnavailableZip469557031
--- FAIL: TestUnavailableZip (72.46s)
=== RUN   TestUnavailableZip/server_1
[debug --host=127.0.0.1:37353 --insecure=true zip --concurrency=1 --cpu-profile-duration=0 /dev/null --timeout=.5s]
    testutils.go:122: panic: runtime error: invalid memory address or nil pointer dereference
    --- FAIL: TestUnavailableZip/server_1 (30.73s)

Parameters:

  • attempt=1
  • run=14
  • shard=4
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@dhartunian dhartunian mentioned this issue Dec 28, 2023
Merged
dhartunian added a commit to dhartunian/cockroach that referenced this issue Dec 28, 2023
@dhartunian
cli: remove t field from TestCLI usage
1c9d761 
Currently, these tests fail in CI with a nil pointer at runtime when
we call `c.t.Fail` when an error is produced.

This change removes the sharing of the `t` variable with `TestCLI`
since it seems to result in a conflict between the outer test code and
what runs inside `RunWithCapture`.

I was unable to reproduce the error locally and do not have further
clues. My hope is that, the simplified error handling will surface the
actual error in CI instead of the continued nil pointer exception.

Resolves: cockroachdb#116228
Epic: None
Release note: None
craig bot pushed a commit that referenced this issue Dec 28, 2023
@dhartunian
Merge #117137
d0760e6 
117137: cli: remove `t` field from `TestCLI` usage r=abarganier a=dhartunian

Currently, these tests fail in CI with a nil pointer at runtime when we call `c.t.Fail` when an error is produced.

This change removes the sharing of the `t` variable with `TestCLI` since it seems to result in a conflict between the outer test code and what runs inside `RunWithCapture`.

I was unable to reproduce the error locally and do not have further clues. My hope is that, the simplified error handling will surface the actual error in CI instead of the continued nil pointer exception.

Resolves: #116228
Epic: None
Release note: None

Co-authored-by: David Hartunian <[email protected]>
@craig craig bot closed this as completed in #117137 Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhartunian dhartunian

Labels
A-observability-inf branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-1 Issues/test failures with a fix SLA of 1 month release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Projects
None yet
Milestone
24.1
Development

Successfully merging a pull request may close this issue.

cli: remove t field from TestCLI usage dhartunian/cockroach
2 participants
@dhartunian @cockroach-teamcity