Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admission: add extra info when deadline reached in flowcontrol #115262

Merged
merged 1 commit into from
Nov 30, 2023
Merged

admission: add extra info when deadline reached in flowcontrol #115262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/kv/kvserver/kvflowcontrol/kvflowcontroller/kvflowcontroller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,11 @@ func (c *Controller) Admit(
return true, nil
}
} else if waitEndState == contextCanceled {
log.VEventf(ctx, 2,
"canceled after waiting (pri=%s stream=%s wait-duration=%s mode=%s)",
pri, connection.Stream(), waitDuration, c.mode())
const formatStr = "canceled after waiting (pri=%s stream=%s wait-duration=%s mode=%s)"
log.VEventf(ctx, 2, formatStr, pri, connection.Stream(), waitDuration, c.mode())
c.metrics.onErrored(class, waitDuration)
return false, ctx.Err()
err := errors.Newf(formatStr, pri, connection.Stream(), waitDuration, c.mode())
return false, errors.CombineErrors(err, ctx.Err())
} else {
log.VEventf(ctx, 2,
"bypassed as stream disconnected (pri=%s stream=%s wait-duration=%s mode=%s)",
Expand Down