admission: add extra info when deadline reached in flowcontrol #115262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
aadityasondhi
added
the
backport-23.2.x
This patch improves the error message when context deadline is reached in flowcontrol wait queue. It includes priority, wait duration, stream. Informs: cockroachdb#113990 Release note: None
aadityasondhi
force-pushed
the
20231129.flow-control-deadline-error
branch
from
86afc34 to
073f71c
Compare
sumeerbhola
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @aadityasondhi)
aadityasondhi
commented
Nov 30, 2023
There was a problem hiding this comment.
TFTR!
bors r=sumeerbhola
Reviewable status:
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves the error message when context deadline is reached in flowcontrol wait queue. It includes priority, wait duration, stream.
Informs: #113990
Release note: None