Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: roachtest/cdc/mixed-versions: use mixed version framework #109247

Merged
merged 1 commit into from
Aug 22, 2023
Merged

release-23.1: roachtest/cdc/mixed-versions: use mixed version framework #109247

merged 1 commit into from
Aug 22, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Aug 22, 2023 •
edited by renatolabs
Loading

Backport 1/1 commits from #108802 on behalf of @jayshrivastava.

/cc @cockroachdb/release

This change updates the cdc/mixed-versions roachtest to use the mixed version testing framework. This mixed version testing framework is better than the previous framework because it offers testing for multiple upgrades. It will also make it easier to maintain and expand this cdc-specific test.

Informs: #107451
Epic: None
Release note: None

Release justification: test-only changes.

@jayshrivastava
roachtest/cdc/mixed-versions: use mixed version framework
0ef2e3f 
This change updates the `cdc/mixed-versions` roachtest to use
the mixed version testing framework. This mixed version testing
framework is better than the previous framework because it offers
testing for multiple upgrades. It will also make it easier to
maintain and expand this cdc-specific test.

Informs: #107451
Epic: None
Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner August 22, 2023 16:14
@blathers-crl blathers-crl bot requested review from herkolategan and DarrylWong and removed request for a team August 22, 2023 16:14
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-108802 branch from a16ab19 to f8e1198 Compare August 22, 2023 16:14
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Aug 22, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-108802 branch from 0ced659 to 0ef2e3f Compare August 22, 2023 16:14
@blathers-crl
Copy link
Author

blathers-crl bot commented Aug 22, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jayshrivastava jayshrivastava merged commit 662a60c into release-23.1 Aug 22, 2023
@jayshrivastava jayshrivastava deleted the blathers/backport-release-23.1-108802 branch August 22, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatolabs renatolabs renatolabs approved these changes

@herkolategan herkolategan Awaiting requested review from herkolategan herkolategan is a code owner automatically assigned from cockroachdb/test-eng

@DarrylWong DarrylWong Awaiting requested review from DarrylWong DarrylWong is a code owner automatically assigned from cockroachdb/test-eng

@HonoreDB HonoreDB Awaiting requested review from HonoreDB

@jayshrivastava jayshrivastava Awaiting requested review from jayshrivastava

@miretskiy miretskiy Awaiting requested review from miretskiy

@rachitgsrivastava rachitgsrivastava Awaiting requested review from rachitgsrivastava

Assignees

@jayshrivastava jayshrivastava

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @renatolabs @jayshrivastava