Skip to content

Commit

Permalink
roachtest/cdc/mixed-versions: use mixed version framework
Browse files Browse the repository at this point in the history
This change updates the `cdc/mixed-versions` roachtest to use
the mixed version testing framework. This mixed version testing
framework is better than the previous framework because it offers
testing for multiple upgrades. It will also make it easier to
maintain and expand this cdc-specific test.

Informs: #107451
Epic: None
Release note: None
  • Loading branch information
jayshrivastava committed Aug 14, 2023
1 parent a16ab19 commit 0ef2e3f
Show file tree
Hide file tree
Showing 2 changed files with 286 additions and 258 deletions.
4 changes: 2 additions & 2 deletions pkg/cmd/roachtest/tests/cdc.go
Original file line number Diff line number Diff line change
Expand Up @@ -641,7 +641,7 @@ func runCDCBank(ctx context.Context, t test.Test, c cluster.Cluster) {
t.Fatal(err)
}

tc, err := kafka.consumer(ctx, "bank")
tc, err := kafka.newConsumer(ctx, "bank")
if err != nil {
t.Fatal(errors.Wrap(err, "could not create kafka consumer"))
}
Expand Down Expand Up @@ -2242,7 +2242,7 @@ func (k kafkaManager) createTopic(ctx context.Context, topic string) error {
})
}

func (k kafkaManager) consumer(ctx context.Context, topic string) (*topicConsumer, error) {
func (k kafkaManager) newConsumer(ctx context.Context, topic string) (*topicConsumer, error) {
kafkaAddrs := []string{k.consumerURL(ctx)}
config := sarama.NewConfig()
// I was seeing "error processing FetchRequest: kafka: error decoding
Expand Down
Loading

0 comments on commit 0ef2e3f

Please sign in to comment.