Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: failover: re-enable disk stall detector in diskStallFailer.Ready #107251

Merged
merged 1 commit into from
Jul 20, 2023
Merged

release-23.1: failover: re-enable disk stall detector in diskStallFailer.Ready #107251

merged 1 commit into from
Jul 20, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jul 20, 2023

Backport 1/1 commits from #106893 on behalf of @erikgrinaker.

/cc @cockroachdb/release

pauseFailer needs to disable the disk stall detector to avoid false positives. However, it attempted to re-enable it via cluster setting during recovery. If a system range is unavailable during recovery (typically in chaos tests with concurrent failures), this can error out.

This patch instead (re-)enables the disk stall detector during diskStallFailer.Ready.

Touches #106681.
Touches #106752.

Epic: none
Release note: None

Release justification:

@blathers-crl blathers-crl bot requested a review from a team as a code owner July 20, 2023 11:44
@blathers-crl blathers-crl bot requested review from herkolategan and removed request for a team July 20, 2023 11:44
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-106893 branch from 1b787b5 to dad8842 Compare July 20, 2023 11:44
@blathers-crl blathers-crl bot requested a review from renatolabs July 20, 2023 11:44
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jul 20, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-106893 branch from b08e7bd to d2d5228 Compare July 20, 2023 11:44
@blathers-crl
Copy link
Author

blathers-crl bot commented Jul 20, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker
failover: re-enable disk stall detector in diskStallFailer.Ready
a4fee7d 
`pauseFailer` needs to disable the disk stall detector to avoid false
positives. However, it attempted to re-enable it via cluster setting
during recovery. If a system range is unavailable during recovery
(typically in chaos tests with concurrent failures), this can error out.

This patch instead (re-)enables the disk stall detector during
`diskStallFailer.Ready`.

Epic: none
Release note: None
@erikgrinaker erikgrinaker force-pushed the blathers/backport-release-23.1-106893 branch from d2d5228 to a4fee7d Compare July 20, 2023 15:22
@erikgrinaker erikgrinaker merged commit d6509cd into release-23.1 Jul 20, 2023
@erikgrinaker erikgrinaker deleted the blathers/backport-release-23.1-106893 branch July 20, 2023 16:26
This was referenced Jul 22, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbg tbg tbg approved these changes

@herkolategan herkolategan Awaiting requested review from herkolategan herkolategan is a code owner automatically assigned from cockroachdb/test-eng

@renatolabs renatolabs Awaiting requested review from renatolabs renatolabs is a code owner automatically assigned from cockroachdb/test-eng

@andrewbaptist andrewbaptist Awaiting requested review from andrewbaptist

@srosenberg srosenberg Awaiting requested review from srosenberg

Assignees

@erikgrinaker erikgrinaker

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @tbg @erikgrinaker