Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: failover/chaos/read-only/lease=expiration failed #106752

Closed
cockroach-teamcity opened this issue Jul 13, 2023 · 3 comments
Closed

roachtest: failover/chaos/read-only/lease=expiration failed #106752

cockroach-teamcity opened this issue Jul 13, 2023 · 3 comments
Assignees
@erikgrinaker
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. X-duplicate Closed as a duplicate of another issue.
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jul 13, 2023 •
edited by exalate-issue-sync bot
Loading

roachtest.failover/chaos/read-only/lease=expiration failed with artifacts on release-23.1 @ 0efd1568d09a5c6a54ae41b0bbf42c682331d24b:

(assertions.go:262).Fail: 
	Error Trace:	github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/failover.go:1434
	            				github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/failover.go:318
	            				main/pkg/cmd/roachtest/monitor.go:105
	            				golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75
	            				GOROOT/src/runtime/asm_amd64.s:1594
	Error:      	Received unexpected error:
	            	pq: setting updated but timed out waiting to read new value
	Test:       	failover/chaos/read-only/lease=expiration
(require.go:1264).NoError: FailNow called
(monitor.go:137).Wait: monitor failure: monitor task failed: t.Fatal() was called
(cluster.go:2249).Run: cluster.RunE: context canceled
(cluster.go:2249).Run: cluster.RunE: context canceled
(cluster.go:2249).Run: cluster.RunE: context canceled
(cluster.go:2249).Run: cluster.RunE: context canceled
test artifacts and logs in: /artifacts/failover/chaos/read-only/lease=expiration/run_1

Parameters: ROACHTEST_arch=amd64 , ROACHTEST_cloud=gce , ROACHTEST_cpu=2 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

/cc @cockroachdb/kv-triage

This test on roachdash | Improve this report!

Jira issue: CRDB-29703

Epic CRDB-27234
@cockroach-teamcity cockroach-teamcity added branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-kv KV Team labels Jul 13, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Jul 13, 2023
@erikgrinaker
Copy link
Contributor

Dupe of #106681.

@erikgrinaker erikgrinaker added X-duplicate Closed as a duplicate of another issue. and removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Jul 17, 2023
@erikgrinaker erikgrinaker added T-kv-replication and removed T-kv KV Team labels Jul 17, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jul 17, 2023

cc @cockroachdb/replication

@erikgrinaker erikgrinaker mentioned this issue Jul 17, 2023
Merged
craig bot pushed a commit that referenced this issue Jul 20, 2023
@erikgrinaker
Merge #106893
f26d46c 
106893: failover: re-enable disk stall detector in `diskStallFailer.Ready` r=erikgrinaker a=erikgrinaker

`pauseFailer` needs to disable the disk stall detector to avoid false positives. However, it attempted to re-enable it via cluster setting during recovery. If a system range is unavailable during recovery (typically in chaos tests with concurrent failures), this can error out.

This patch instead (re-)enables the disk stall detector during `diskStallFailer.Ready`.

Touches #106681.
Touches #106752.

Epic: none
Release note: None

Co-authored-by: Erik Grinaker <[email protected]>
@blathers-crl blathers-crl bot mentioned this issue Jul 20, 2023
Merged
@erikgrinaker
Copy link
Contributor

Resolved by #107251.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. X-duplicate Closed as a duplicate of another issue.
Projects
None yet
Milestone
23.1
Development

No branches or pull requests
3 participants
@erikgrinaker @cockroach-teamcity @andrewbaptist