changefeedccl: surface errors when job fails in alter changefeed tests #106438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alter changefeed tests use SucceedsSoon around checking various things to do with a job's progress, which leads to an unhelpful hardcoded error message if the job has actually failed entirely. This commit extracts the logic into a test helper and makes it surface job errors. Fixes: cockroachdb#102760
|
This change is |
miretskiy
approved these changes
Jul 7, 2023
|
bors r=[miretskiy] |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alter changefeed tests use SucceedsSoon around checking various things to do with a job's progress, which leads to an unhelpful hardcoded error message if the job has actually failed entirely. This commit extracts the logic into a test helper and makes it surface job errors.
Fixes: #102760