Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccl/changefeedccl: TestAlterChangefeedAddTargetsDuringSchemaChangeError failed #102760

Closed
cockroach-teamcity opened this issue May 4, 2023 · 1 comment · Fixed by #106438
Closed

ccl/changefeedccl: TestAlterChangefeedAddTargetsDuringSchemaChangeError failed #102760

cockroach-teamcity opened this issue May 4, 2023 · 1 comment · Fixed by #106438
Assignees
@HonoreDB
Labels
A-cdc Change Data Capture branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-cdc
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented May 4, 2023 •
edited by exalate-issue-sync bot
Loading

ccl/changefeedccl.TestAlterChangefeedAddTargetsDuringSchemaChangeError failed with artifacts on release-23.1.0 @ 5efa6ff20f56d2ce8111b710190d1b378adb26d9:

=== RUN   TestAlterChangefeedAddTargetsDuringSchemaChangeError
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/905465f697dc04c39f7d8a82cb057bfe/logTestAlterChangefeedAddTargetsDuringSchemaChangeError3312473349
    test_log_scope.go:79: use -show-logs to present logs inline
=== CONT  TestAlterChangefeedAddTargetsDuringSchemaChangeError
    alter_changefeed_test.go:1257: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/905465f697dc04c39f7d8a82cb057bfe/logTestAlterChangefeedAddTargetsDuringSchemaChangeError3312473349
--- FAIL: TestAlterChangefeedAddTargetsDuringSchemaChangeError (55.34s)
=== RUN   TestAlterChangefeedAddTargetsDuringSchemaChangeError/kafka
    helpers_test.go:817: making server as secondary tenant
    helpers_test.go:895: making kafka feed factory
    alter_changefeed_test.go:1238: condition failed to evaluate within 45s: waiting for checkpoint
    --- FAIL: TestAlterChangefeedAddTargetsDuringSchemaChangeError/kafka (55.33s)

Parameters: TAGS=bazel,gss

Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/cdc

This test on roachdash | Improve this report!

Jira issue: CRDB-27639

Epic CRDB-11732
@cockroach-teamcity cockroach-teamcity added branch-release-23.1.0 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels May 4, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone May 4, 2023
@tbg tbg added the T-cdc label Jun 30, 2023
@blathers-crl blathers-crl bot added the A-cdc Change Data Capture label Jun 30, 2023
@HonoreDB HonoreDB mentioned this issue Jul 7, 2023
Merged
HonoreDB added a commit to HonoreDB/cockroach that referenced this issue Jul 7, 2023
@HonoreDB
changefeedccl: surface errors when job fails in alter changefeed tests
70c51c0 
Alter changefeed tests use SucceedsSoon around checking various things
to do with a job's progress, which leads to an unhelpful hardcoded error
message if the job has actually failed entirely. This commit extracts
the logic into a test helper and makes it surface job errors.

Fixes: cockroachdb#102760
@shermanCRL shermanCRL added the branch-master Failures and bugs on the master branch. label Jul 8, 2023
@miretskiy
Copy link
Contributor

I'm going to close this test: 100k+ runs w/ no failures.

craig bot pushed a commit that referenced this issue Jul 10, 2023
@HonoreDB
Merge #106438
71ff6f9 
106438: changefeedccl: surface errors when job fails in alter changefeed tests r=[miretskiy] a=HonoreDB

Alter changefeed tests use SucceedsSoon around checking various things to do with a job's progress, which leads to an unhelpful hardcoded error message if the job has actually failed entirely. This commit extracts the logic into a test helper and makes it surface job errors.

Fixes: #102760

Co-authored-by: Aaron Zinger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HonoreDB HonoreDB

Labels
A-cdc Change Data Capture branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-cdc
Projects
None yet
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

changefeedccl: surface errors when job fails in alter changefeed tests HonoreDB/cockroach
5 participants
@HonoreDB @tbg @cockroach-teamcity @miretskiy @shermanCRL