sql: disable strict gc ttl enforcement in schema changer test #105069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the TestRaceWithBackfill test would add a zone config to force garbage collection to happen frequently, however this could cause a race between batch timestamps and garbage collection thresholds. This change adds a call to `DisableGCTTLStrictEnforcement`, which is supposed to be called before updating the zone config with `AddImmediateGCZoneConfig` for testing purposes. Epic: None Fixes: cockroachdb#104655 Release note: None
|
This change is |
|
Test failure is known issue #99770 unrelated to this PR. |
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the TestRaceWithBackfill test would add a zone config to force garbage collection to happen frequently, however this could cause a race between batch timestamps and garbage collection thresholds. This change adds a call to
DisableGCTTLStrictEnforcement, which is supposed to be called before updating the zone config withAddImmediateGCZoneConfigfor testing purposes.Epic: None
Fixes: #104655
Release note: None